chatmail / chatmail/core

Forwarded sticker's quote points to last message of target chat

Open
#8,053 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
929
Forks
143
Avg merge
1d 20h
Merged PRs (30d)
53

Description

- Operating System (Linux/Mac/Windows/iOS/Android):
- Core Version: 2.47.0
- Client Version: latest main

## Expected behavior

Something sane.

## Actual behavior

The forwarded message has a quote whose author is the author of the prior last message in chat 2. However, the text of the quote is the text of the message from step 1.

### Steps to reproduce the problem

1. Send a message to chat 1.
2. Reply with a sticker to that message (only possible on Android as of writing).
3. Forward the reply to chat 2.

### Screenshots

Image

### Logs

Related:
- https://github.com/chatmail/core/issues/2325
- https://github.com/chatmail/core/pull/2526

Some relevant code:

https://github.com/chatmail/core/blob/2637c3bea415de3af55fd79b2f9aba2e3ee57c5e/src/message.rs#L1267-L1273

https://github.com/chatmail/core/blob/2637c3bea415de3af55fd79b2f9aba2e3ee57c5e/src/chat.rs#L4497-L4504

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.