chatmail / chatmail/async-native-tls

Align API with origin native-tls

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
74
Forks
25
PR merge metrics
No merged PRs in 30d

Description

`TlsAcceptor::new` accepts a file and a password as parameters. It goes against the constructor in the origin `native-tls` crate where it accepts `Identity`. Due to `Identity` is encapsulated `from_pkcs8` method is missed.

I think this crate should extend the origin one, not override it.

Could you align API of both crates one to one? Or add other possibility to use `from_pkcs8` method?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.