chartjs / chartjs/Chart.js

Type error setting pointStype to false

Open
#11,368 2 comments 0 reactions 0 assignees View on GitHub
type: bug type: types
Dominant language
JavaScript
Stars
67.7k
Forks
11.9k
Avg merge
7h 39m
Merged PRs (30d)
5

Description

### Expected behavior

I hope I can define a dataset with a boolean pointStyle without getting a typing error

### Current behavior

When i add the following config:

```typescript
new Chart(canvas, {
type: 'line',
data: {
labels: generateLabels(),
datasets: [
{
label: 'Dataset',
data: generateData(),
pointStyle: false, <--
},
],
}
```

I get the following typing error

_Type '{ pointStyle: boolean; }' is not assignable to type 'ChartDatasetCustomTypesPerDataset<"line", number[]>'._

### Reproducible sample

https://codesandbox.io/s/ng2charts-chart-js-issue-template-forked-r5kcm4

Updated example: https://codesandbox.io/s/ng2charts-chart-js-issue-template-forked-6fd62d?file=/src/app/app.component.ts

(does not complain about the boolean type, but neither does it complain about an invalid string type)

### Optional extra steps/info to reproduce

_No response_

### Possible solution

It is currently "fixed" by forcing a type as shown here

`pointStyle: false as unknown as string,`

but I wouldn't want to have to do this.

### Context

I am working on Angular 16

### chart.js version

4.3.0

### Browser name and version

Firefox Developer Edition 115.0b9 (64-bit) on Ubuntu

### Link to your project

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.