chartjs / chartjs/Chart.js

Convert Scale Legacy Callbacks to Plugin Hooks

Open
#10,155 0 comments 0 reactions 0 assignees View on GitHub
breaking change type: enhancement
Dominant language
JavaScript
Stars
67.7k
Forks
11.9k
Avg merge
7h 39m
Merged PRs (30d)
5

Description

### Feature Proposal

There are a number of legacy callbacks in scales that should either be removed or replaced with plugin hooks.

Legacy callbacks:
* beforeUpdate
* beforeSetDimensions
* afterSetDimensions
* beforeTickToLabelConversion
* afterTickToLabelConversion
* beforeCalculateLabelRotation
* afterCalculateLabelRotation
* beforeFit
* afterFit
* afterUpdate

### Possible Implementation

Replace direct `call(this.options[plugin]`) with `Scale._callHooks()` as we've already done for `beforeDataLimits`, `afterDataLimits`, `beforeBuildTicks`, `afterBuildTicks`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.