charmbracelet / charmbracelet/vhs

Show full screen output on Wait+Line mismatch

Open
#533 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
20.9k
Forks
474
Avg merge
4d 1h
Merged PRs (30d)
2

Description

**Is your feature request related to a problem? Please describe.**

Thanks to @mastercactapus we've finally the `Wait` feature, but when waiting for a line on failure it's hard to understand the context as the error is just:

```
failed to execute command: timeout waiting for "Line Username:$" to match Username:$; last value was: >
```

**Describe the solution you'd like**

Other than showing the failed line (ideally in a new line so that's clearer), the whole context should be shown as when using `Wait+Screen`

**Describe alternatives you've considered**
Using `Wait+Screen /Username:\n/` is an option but that doesn't make sure that we're matching the last screen line.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the failure handling for Wait+Line with the existing Wait+Screen behavior described in the issue. Done means a Wait+Line mismatch reports the failed line clearly and includes the full screen context, while still matching the last screen line.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.