charmbracelet / charmbracelet/bubbles

Lack of Style Options for Spaces in Full Help View Columns

Open Beginner friendly
#572 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
8.9k
Forks
457
Avg merge
1d 18h
Merged PRs (30d)
5

Description

https://github.com/charmbracelet/bubbles/blob/a9344b59531d1b947978485dea07c5597299889a/help/help.go#L197-L201

In the FullHelpView function, the spaces within the columns created by lipgloss.JoinHorizontal do not have dedicated style options. This results in inconsistent styling, especially when a background color is applied to the terminal. As shown in the attached screenshot, the spaces remain unstyled with no ability to apply custom styles, leading to visual discrepancies.

This issue is similar to the one described in issue #571, where the ShortHelpView function lacks style options for spaces between the key and description.

Screenshot:
![image](https://github.com/user-attachments/assets/1f483e15-3c7a-4f54-abdc-9e0e8cd55c1b)

To resolve this issue, I suggest wrapping the JoinHorizontal call in a Render call of the FullSeparator style. This would allow the other styles to override anything not set by the FullSeparator style, effectively styling the whitespace.

If you settle on an approach, I'm happy to implement it and provide a PR. Thanks again!

Contributor guide

Open the contributing guide

Research direction

Start in help/help.go at the FullHelpView code around lines 197-201, focusing on the lipgloss.JoinHorizontal call and the FullSeparator style. Check how the whitespace between columns is rendered and whether wrapping it in a FullSeparator Render allows other styles to override it. Done means the column spaces can receive custom styling, including terminal background colors, without disrupting the existing FullHelpView layout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.