chancejs / chancejs/chancejs

falsy returns undefined when undefined is not in pool

Open
#522 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6.5k
Forks
461
PR merge metrics
No merged PRs in 30d

Description

The falsey pool parameter isn't working as intended. eg:

`
chance.falsy({pool: [null] });
`

That sometimes produces `undefined`, not sure if it's a bug - bug or the it is trying to also use undefined as a falsy value.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the chance.falsy entry point and trace how its pool parameter is handled. Reproduce the example with pool set to [null], then determine whether undefined is included intentionally; done means the behavior matches the documented pool semantics and is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.