chakra-core / chakra-core/ChakraCore

`this == nullptr` results in undefined behavior

Open
#6,978 3 comments 0 reactions 0 assignees View on GitHub
Codebase Quality
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

## Issue
‘this’ pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true

## Tasks
- [ ] Add compiler warning
clang: [`-Wundefined-bool-conversion`](https://clang.llvm.org/docs/DiagnosticsReference.html#id939)
msvc: ??
- [x] #6847
- [ ] [`IR.cpp`](https://github.com/chakra-core/ChakraCore/blob/2af598f04ab508f9231d6e26f0f82f5a57561413/lib/Backend/IR.cpp#L4852)
- [x] Find further places where this may happen

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.