chakra-core / chakra-core/ChakraCore

Assertion Failure: landingPadValueType.IsSimilar(baseValueType) in ChakraCore/lib/Backend/GlobOptArrays.cpp::GlobOpt::ArraySrcOpt::CheckLoops, line 504

Open
#6,913 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

## Version
commit id: c3ead3f8a6e0bb8e32e043adc091c68cba5935e9

## Platform
Ubuntu 20.04.5 LTS (Linux 5.4.0-144-generic x86_64)

## Build
- Debug Mode

```
./build.sh --debug --static
```

## PoC
```
for (let i = 0; i < 80; i++) {
for (const j in 2) {
const arr = [1,2,3];
for (let k = arr; k > -2; k = k ** -2) {
arr[4];
}
}
}
```

## Execution steps & Output
```
./ch --maxinterpretcount:10 --maxsimplejitruncount:100 -bgjit- poc.js
ASSERTION 421717: (/home/wjm/ChakraCore/lib/Backend/GlobOptArrays.cpp, line 504) landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType))
Failure: (landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType)))
Signal: SIGILL (Illegal instruction)
```
## Backtrace
```
(lldb) bt
* thread #1, name = 'ch', stop reason = signal SIGILL: illegal instruction operand
* frame #0: 0x0000555556bb6c42 ch`GlobOpt::ArraySrcOpt::CheckLoops(this=0x00007fffffff8098) at GlobOptArrays.cpp:501:13
frame #1: 0x0000555556bc14e4 ch`GlobOpt::ArraySrcOpt::Optimize(this=0x00007fffffff8098) at GlobOptArrays.cpp:1869:9
frame #2: 0x0000555556b5fae3 ch`GlobOpt::OptArraySrc(this=0x00007fffffff9800, instrRef=0x00007fffffff8678, src1Val=0x00007fffffff8510, src2Val=0x00007fffffff8508) at GlobOpt.cpp:13452:17
frame #3: 0x0000555556b49f2e ch`GlobOpt::OptInstr(this=0x00007fffffff9800, instr=0x00007fffffff8678, isInstrRemoved=0x00007fffffff866e) at GlobOpt.cpp:2563:5
frame #4: 0x0000555556b46dce ch`GlobOpt::OptBlock(this=0x00007fffffff9800, block=0x00007ff7e7c08980) at GlobOpt.cpp:521:27
frame #5: 0x0000555556b458a7 ch`GlobOpt::ForwardPass(this=0x00007fffffff9800) at GlobOpt.cpp:402:15
frame #6: 0x0000555556b44ab3 ch`GlobOpt::Optimize(this=0x00007fffffff9800) at GlobOpt.cpp:212:15
frame #7: 0x0000555556b262ab ch`Func::TryCodegen(this=0x00007fffffff9eb0) at Func.cpp:457:21
frame #8: 0x0000555556b25ae0 ch`Func::Codegen(alloc=0x00007fffffffa470, workItem=0x00007ff7e7bf4030, threadContextInfo=0x0000555557eb71b8, scriptContextInfo=0x0000555557ee9138, outputData=0x00007fffffffa8b0, epInfo=0x00007ff7e7c64200, runtimeInfo=0x0000000000000000, polymorphicInlineCacheInfo=0x00007ff7e7c3f3c0, codeGenAllocators=0x0000555557ef5dd8, codeGenProfiler=0x0000000000000000, isBackgroundJIT=false) at Func.cpp:325:18
frame #9: 0x000055555690ef90 ch`NativeCodeGenerator::CodeGen(this=0x0000555557eea908, pageAllocator=0x0000555557eb7540, workItemData=0x0000555557ef5c50, jitWriteData=0x00007fffffffa8b0, foreground=true, epInfo=0x00007ff7e7c64200) at NativeCodeGenerator.cpp:890:9
frame #10: 0x0000555556910c28 ch`NativeCodeGenerator::CodeGen(this=0x0000555557eea908, pageAllocator=0x0000555557eb7540, workItem=0x0000555557ef5c28, foreground=true) at NativeCodeGenerator.cpp:1007:5
frame #11: 0x00005555569139a7 ch`NativeCodeGenerator::Process(this=0x0000555557eea908, job=0x0000555557ef5c30, threadData=0x0000000000000000) at NativeCodeGenerator.cpp:1895:13
frame #12: 0x00005555569b83d4 ch`JsUtil::ForegroundJobProcessor::Process(job=0x0000555557ef5c30) at Jobs.cpp:426:36
frame #13: 0x0000555556922bc3 ch`void JsUtil::ForegroundJobProcessor::PrioritizeJobAndWait(this=0x0000555557ea2ce8, manager=0x0000555557eea908, holder=0x00007ff7e7c64200, function=0x0000000000000000) at Jobs.inl:207:36
frame #14: 0x0000555556918804 ch`void JsUtil::JobProcessor::PrioritizeJobAndWait(this=0x0000555557ea2ce8, manager=0x0000555557eea908, holder=0x00007ff7e7c64200, function=0x0000000000000000) at Jobs.inl:81:58
frame #15: 0x000055555690d4fc ch`NativeCodeGenerator::GenerateLoopBody(this=0x0000555557eea908, fn=0x00007ff7e7c47000, loopHeader=0x00007ff7e7c77810, entryPoint=0x00007ff7e7c64200, localCount=18, localSlots=0x00007fffffffc0d0) at NativeCodeGenerator.cpp:711:22
frame #16: 0x00005555568157dd ch`GenerateLoopBody(nativeCodeGen=0x0000555557eea908, fn=0x00007ff7e7c47000, loopHeader=0x00007ff7e7c77810, info=0x00007ff7e7c64200, localCount=18, localSlots=0x00007fffffffc0d0) at BackendApi.cpp:88:20
frame #17: 0x0000555555fb220b ch`Js::InterpreterStackFrame::DoLoopBodyStart(this=0x00007fffffffbf70, loopNumber=1, layoutSize=SmallLayout, doProfileLoopCheck=true, isFirstIteration=false) at InterpreterStackFrame.cpp:6277:17
frame #18: 0x0000555555fb5997 ch`void Js::InterpreterStackFrame::LoopBodyStart(this=0x00007fffffffbf70, loopNumber=1, layoutSize=SmallLayout, isFirstIteration=false) at InterpreterStackFrame.cpp:5994:9
frame #19: 0x0000555556002d38 ch`unsigned char const* Js::InterpreterStackFrame::OP_ProfiledLoopBodyStart<(Js::LayoutSize)0, false>(this=0x00007fffffffbf70, loopId=1) at InterpreterStackFrame.cpp:5902:9
frame #20: 0x0000555555fcd716 ch`unsigned char const* Js::InterpreterStackFrame::OP_ProfiledLoopBodyStart<(Js::LayoutSize)0, false>(this=0x00007fffffffbf70, ip="\xe69") at InterpreterStackFrame.cpp:5774:16
frame #21: 0x0000555555e704b1 ch`Js::InterpreterStackFrame::ProcessUnprofiled(this=0x00007fffffffbf70) at InterpreterHandler.inl:52:3
frame #22: 0x0000555555e522be ch`Js::InterpreterStackFrame::Process(this=0x00007fffffffbf70) at InterpreterStackFrame.cpp:3495:22
frame #23: 0x0000555555e50dd3 ch`Js::InterpreterStackFrame::InterpreterHelper(function=0x00007ff7e7c76730, args=ArgumentReader @ 0x00007fffffffc530, returnAddress=0x00007ff7e7bd0fa2, addressOfReturnAddress=0x00007fffffffc578, asmJsReturn=0x0000000000000000) at InterpreterStackFrame.cpp:2153:40
frame #24: 0x0000555555e4feb0 ch`Js::InterpreterStackFrame::InterpreterThunk(layout=0x00007fffffffc590) at InterpreterStackFrame.cpp:1833:16
frame #25: 0x00007ff7e7bd0fa2
frame #26: 0x00005555564a37de ch`amd64_CallFunction at JavascriptFunctionA.S:100
frame #27: 0x00005555561d7a4b ch`void* Js::JavascriptFunction::CallFunction(function=0x00007ff7e7c76730, entryPoint=(ch`NativeCodeGenerator::CheckCodeGenThunk(Js::RecyclableObject*, Js::CallInfo, ...)), args=Arguments @ 0x00007fffffffc798, useLargeArgCount=false)(Js::RecyclableObject*, Js::CallInfo, ...), Js::Arguments, bool) at JavascriptFunction.cpp:1364:16
frame #28: 0x00005555561cf2f4 ch`Js::JavascriptFunction::CallRootFunctionInternal(obj=0x00007ff7e7c76730, args=Arguments @ 0x00007fffffffc810, scriptContext=0x0000555557ee9138, inScript=true) at JavascriptFunction.cpp:772:24
frame #29: 0x00005555561cf10c ch`Js::JavascriptFunction::CallRootFunction(obj=0x00007ff7e7c76730, args=, scriptContext=0x0000555557ee9138, inScript=true) at JavascriptFunction.cpp:717:15
frame #30: 0x00005555561cf0b1 ch`Js::JavascriptFunction::CallRootFunction(this=0x00007ff7e7c76730, args=, scriptContext=0x0000555557ee9138, inScript=true) at JavascriptFunction.cpp:832:16
frame #31: 0x0000555555894a8e ch`RunScriptCore(this=0x00007fffffffcbe0, scriptContext=0x0000555557ee9138, _actionEntryPopper=0x00007fffffffcbc0)::$_85::operator()(Js::ScriptContext*, TTD::TTDJsRTActionResultAutoRecorder&) const at Jsrt.cpp:3705:49
frame #32: 0x0000555555894624 ch`_JsErrorCode ContextAPIWrapper(this=0x00007fffffffcb78, scriptContext=0x0000555557ee9138)::$_85)::'lambda'(Js::ScriptContext*)::operator()(Js::ScriptContext*) const at JsrtInternal.h:237:16
frame #33: 0x0000555555893fc4 ch`_JsErrorCode ContextAPIWrapper_Core(RunScriptCore(void*, unsigned char const*, unsigned long, LoadScriptFlag, unsigned long, char16_t const*, bool, _JsParseScriptAttributes, bool, void**)::$_85)::'lambda'(Js::ScriptContext*)>(fn=(anonymous class) @ 0x00007fffffffcb78)::$_85) at JsrtInternal.h:192:23
frame #34: 0x00005555558608f6 ch`_JsErrorCode ContextAPIWrapper(fn=(anonymous class) @ 0x00007fffffffcbe0)::$_85) at JsrtInternal.h:235:27
frame #35: 0x00005555558607fb ch`RunScriptCore(scriptSource=0x00007ff7e7c44000, script="for (let i = 0; i < 80; i++) {\n for (const j in 2) {\n const arr = [1,2,3];\n for (let k = arr; k > -2; k = k ** -2) {\n arr[4];\n }\n }\n}\n// CRASH INFO\n// ==========\n// TERMSIG: 4\n// STDERR:\n// ASSERTION 603064: (/home/wjm/ChakraCore/lib/Backend/GlobOptArrays.cpp, line 504) landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType))\n// Failure: (landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType)))\n// STDOUT:\n// ARGS: /home/wjm/ChakraCore/out/Debug/ch --maxinterpretcount:10 --maxsimplejitruncount:100 -bgjit- -reprl fuzzcode.js\n// EXECUTION TI"..., cb=1408, loadScriptFlag=LoadScriptFlag_Utf8Source | LoadScriptFlag_ExternalArrayBuffer, sourceContext=0, sourceUrl=u"/home/wjm/DiTing-pocs/chakra/bug27_optArray.js", parseOnly=false, parseAttributes=JsParseScriptAttributeNone, isSourceModule=false, result=0x0000000000000000) at Jsrt.cpp:3656:12
frame #36: 0x0000555555862f6e ch`::JsRun(JsValueRef, JsSourceContext, JsValueRef, JsParseScriptAttributes, JsValueRef *) [inlined] CompileRun(scriptVal=0x00007ff7e7c44000, sourceContext=0, sourceUrl=0x00007ff7e7c71cf0, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000, parseOnly=false) at Jsrt.cpp:5019:12
frame #37: 0x0000555555862db9 ch`::JsRun(scriptVal=0x00007ff7e7c44000, sourceContext=0, sourceUrl=0x00007ff7e7c71cf0, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000) at Jsrt.cpp:5041
frame #38: 0x0000555555787293 ch`ChakraRTInterface::JsRun(script=0x00007ff7e7c44000, sourceContext=0, sourceUrl=0x00007ff7e7c71cf0, parseAttributes=JsParseScriptAttributeNone, result=0x0000000000000000) at ChakraRtInterface.h:487:179
frame #39: 0x0000555555784924 ch`RunScript(fileName="bug27_optArray.js", fileContents="for (let i = 0; i < 80; i++) {\n for (const j in 2) {\n const arr = [1,2,3];\n for (let k = arr; k > -2; k = k ** -2) {\n arr[4];\n }\n }\n}\n// CRASH INFO\n// ==========\n// TERMSIG: 4\n// STDERR:\n// ASSERTION 603064: (/home/wjm/ChakraCore/lib/Backend/GlobOptArrays.cpp, line 504) landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType))\n// Failure: (landingPadValueType.IsSimilar(baseValueType) || (landingPadValueType.IsLikelyNativeArray() && landingPadValueType.Merge(baseValueType).IsSimilar(baseValueType)) || (baseValueType.IsLikelyNativeArray() && baseValueType.Merge(landingPadValueType).IsSimilar(landingPadValueType)))\n// STDOUT:\n// ARGS: /home/wjm/ChakraCore/out/Debug/ch --maxinterpretcount:10 --maxsimplejitruncount:100 -bgjit- -reprl fuzzcode.js\n// EXECUTION TI"..., fileLength=1408, fileContentsFinalizeCallback=(ch`WScriptJsrt::FinalizeFree(void*) at WScriptJsrt.cpp:217), bufferValue=0x0000000000000000, fullPath="/home/wjm/DiTing-pocs/chakra/bug27_optArray.js", parserStateCache=0x0000000000000000)(void*), void*, char*, void*) at ch.cpp:451:25
frame #40: 0x00005555557863f0 ch`ExecuteTest(fileName="bug27_optArray.js") at ch.cpp:917:13
frame #41: 0x00005555557864ac ch`ExecuteTestWithMemoryCheck(fileName="bug27_optArray.js") at ch.cpp:967:10
frame #42: 0x0000555555786d7a ch`main(argc=5, c_argv=0x00007fffffffd648) at ch.cpp:1274:20
frame #43: 0x00007ffff778d1e2 libc.so.6`__libc_start_main + 242
frame #44: 0x0000555555783b7e ch`_start + 46
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the assertion with the provided PoC using the debug static build and the shown ch options. Start at GlobOptArrays.cpp::GlobOpt::ArraySrcOpt::CheckLoops line 504, then trace the callers through GlobOpt.cpp::OptArraySrc and Func.cpp::TryCodegen. Done means the PoC no longer triggers the landingPadValueType assertion.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, javascript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.