chakra-core / chakra-core/ChakraCore

Review flag NTBUILD

Open
#6,544 8 comments 0 reactions 0 assignees View on GitHub
Codebase Quality help wanted
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

The flag NTBUILD is used to guard various features included in chakra.dll but not in chakracore, I believe that most of the code behind it is not functional without additional code that is not in this repository and is unlikely to be made available.

We should therefore review and consider deleting as dead code anything wrapped with `#ifdef NTBUILD`. There is a possibility that some of this code could be usable for some other purpose - hence a review rather than immediate deletion.

Additionally the following flags are turned on by enabling NTBUILD - each of these should be individually reviewed and any code behind them considered for deletion as dead, again should consider in each case if the code can be repurposed or used without the additional code this repository does not contain:

- [x] ENABLE_PROJECTION
- [ ] ENABLE_FOUNDATION_OBJECT
- [x] ENABLE_EXPERIMENTAL_FLAGS
- [ ] ENABLE_WININET_PROFILE_DATA_CACHE
- [ ] ENABLE_COMPRESSION_UTILITIES
- [ ] ENABLE_BASIC_TELEMETRY
- [x] ENABLE_DOM_FAST_PATH
- [ ] EDIT_AND_CONTINUE
- [ ] ENABLE_JIT_CLAMP
- [ ] ENABLE_SCRIPT_PROFILING

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.