chakra-core / chakra-core/ChakraCore

Detect ICU from CMake

Open
#6,433 0 comments 0 reactions 0 assignees View on GitHub
Dev Experience
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

There is some ICU detection as part of PAL (it checks for `uchar.h`), but ChakraCore main CMake file does not really look for the library, unless `ICU_INCLUDE_PATH` is set.

For 'system ICU` case Linux distros get hardcoded library names, and OSX does not get anything set.

We might need to think what the interaction between EMBED_ICU, SYSTEM_ICU, and ICU_INCLUDE_PATH should be.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.