chakra-core / chakra-core/ChakraCore

Update Intl.DateTimeFormat to use relatedYear

Open
#4,885 7 comments 0 reactions 0 assignees View on GitHub
Intl-ICU
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Currently, formatting to parts with these calendars has a few issues
1) The "year" field is returned as "wu-xu", which is different from Firefox ~60, which returned 35. This may or may not actually be an issue
2) The first part returned is { type: "unknown", value: "2018" } because the ICU type returned in the field position iterator is a UDAT_RELATED_YEAR_TYPE, which is an internal type (Should ICU be returning this at all? The enum value isn't even exposed in Windows Kit ICU, thanks to it being an internal field)
3) The formatted string is "2018(wu-xu)", but the parts only reconstruct to "2018(wu-xu" because we don't account for literals at the end of the string

/cc @dilijev , @jefgen

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.