chakra-core / chakra-core/ChakraCore

Refactor PlatformAgnostic interface into top-level module with no internal dependencies

Open
#4,782 0 comments 0 reactions 0 assignees View on GitHub
Codebase Quality Dev Experience
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Right now, there are two PlatformAgnostic folders -- one in lib\Common and one in lib\Runtime. These should be merged, ridded of Js:: namespace dependencies, and have a pluggable architecture similar to the Utf8Codex,

Sub-items of annoyance:

- [ ] lib\Common\PlatformAgnostic files aren't editable from within VS
- [ ] lib\Runtime\PlatformAgnostic files _shouldn't_ be used by ch and jshost, considering their internal dependencies, but in practice they are needed.
- [ ] Separating PlatformAgnostic out would make it much clearer that we can use the standard library in the implementation, since there is no risk of colliding with our garbage collector.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.