chakra-core / chakra-core/ChakraCore

Type sharing test`Prototypes/ChangePrototype` is flaky on r1.8

Open
#4,530 1 comment 0 reactions 0 assignees View on GitHub
Flaky Test Test Bug
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

CCRobot caught this on release1.8 branch;

```
[1192/2354 0.20] Failed -> Prototypes/ChangePrototype.js
out/Debug/ch -WERExceptionSupport -ExtendedErrorStackForTestHost -BaselineMode -maxInterpretCount:1 -maxSimpleJitRunCount:1 -bgjit- -dynamicprofilecache:profile.dpl.1466 -RecyclerVerifyMark -RecyclerConcurrentStress -VerifyBarrierBit -KeepRecyclerTrackData -trace:TypeShareForChangePrototype -JsBuiltIn- test/Prototypes/ChangePrototype.js
Output: (at line 28)
----------------------------
TypeSharing: Updating prototype object s DictionarySlot cache in __proto__.
----------------------------
Expected Output:
----------------------------
TypeSharing: Reusing prototype object s DictionarySlot cache in __proto__.
----------------------------
exit code: 0
```

Looks like Kunal had prepared the test and the bug fix associated with it almost a year ago. I'm going to assign myself for now and take a look.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.