chakra-core / chakra-core/ChakraCore
Intl: Implement Intl.js version of Array.prototype.toLocaleString (if different)
- Dominant language
- JavaScript
- Stars
- 9.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
If they are indeed different. If they are NOT effectively different in our implementation (I believe this is the case in our implementation), add a note in a comment Intl.js to make this clear for future maintainers.
See: https://github.com/tc39/ecma402/issues/173
See: https://tc39.github.io/ecma402/#sup-array.prototype.tolocalestring
See: https://tc39.github.io/ecma402/#sup-array.prototype.tolocalestring
See also https://tc39.github.io/ecma262/#sec-%typedarray%.prototype.tolocalestring which is dependent on the `Array.prototype.toLocaleString` implementation, and which is much simpler to reason about if `Array.prototype.toLocaleString` is actually implemented in native code instead of JS, the same regardless of Intl (because the only difference is in passing the reserved parameters around, which has the correct effect whether Intl is present or not).
Contributor guide
Assessment
This issue has not been assessed yet.