chakra-core / chakra-core/ChakraCore

Usage of SRCINFO->moduleID for ES6 moduleId may not be appropriate

Open
#2,931 0 comments 0 reactions 0 assignees View on GitHub
Codebase Quality Task
Dominant language
JavaScript
Stars
9.3k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Currently storing ES6 `moduleId` in `SRCINFO->moduleID`.
For example, in `SourceTextModuleRecord::ParseSource()`:

```C++
this->parser = (Parser*)AllocatorNew(ArenaAllocator, allocator, Parser, scriptContext);
srcInfo->moduleID = moduleId;
```

This may not be appropriate and needs investigation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.