SBOM does not get built for minirootfs

Open
#2,084 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
build-system, cli

Research direction

Start in internal/cli/build-minirootfs.go at the --sbom-path option and follow how the argument is passed to BuildMinirootFSCmd. Confirm whether the minirootfs build uses it; done means --sbom-path produces an SBOM when running apko build-minirootfs.

Written by the indexing model from the issue text.

Description

I'm trying to explore using apko to build minirootfs images and I'm exploring SBOM generation as part of this.

When calling apko build-minirootfs --help I see:

      --sbom-path string                     generate an SBOM

Which does appear to come from build-minirootfs.go specifically:

https://github.com/chainguard-dev/apko/blob/dd5a700b95a67ea882e7b59bca6b913afb44954d/internal/cli/build-minirootfs.go#L59

https://github.com/chainguard-dev/apko/blob/dd5a700b95a67ea882e7b59bca6b913afb44954d/internal/cli/build-minirootfs.go#L69

But unless I'm missing something, I think that although that sbomPath argument does get passed into BuildMinirootFSCmd, I don't think the BuildMinirootFSCmd function actually does anything with it.

Am I missing something, or is the SBOM generation not actually fully hooked-up for minirootfs builds?

Dominant language
Go
Stars
1.7k
Forks
228
Avg merge
1d 3h
Merged PRs (30d)
62

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from chainguard-dev/apko

All issues in chainguard-dev/apko

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.