chaijs / chaijs/deep-eql

Assertion error does not state problematic parts for Maps

Open
#61 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
112
Forks
45
Avg merge
2d 21h
Merged PRs (30d)
1

Description

chai.expect(new Map([['a','a']])).to.deep.equal(new Map([['a','b']]))
// AssertionError: expected {} to deeply equal {}
chai.expect([['a','a']]).to.deep.equal([['a','b']])
// AssertionError: expected [ [ 'a', 'a' ] ] to deeply equal [ [ 'a', 'b' ] ]

As you can se it is not clear why it fails from the error message

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Map deep-equality path represented by the failing examples in the issue and trace how assertion errors format compared values. Done means a differing Map entry is identifiable from the error message, while the existing array comparison behavior remains clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.