'function' comparison
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 112
- Forks
- 45
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 1
Description
Due to the way npm hoisting works, two deeply equal instances of the same ES6 class loaded from different locations (node_modules) return false.
Maybe instead of referential equality for functions, Function.toString will be a better way to go?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at index.js line 207, where functions use referential equality, and compare that behavior with Function.toString. Reproduce the deeply equal ES6 class case when classes are loaded from different node_modules locations. Done means the intended comparison behavior is established and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100