cginternals / cginternals/libzeug

Default OPTION_BUILD_WITH_STD_REGEX to false with gcc < 4.9

Open
#121 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16
Forks
12
PR merge metrics
No merged PRs in 30d

Description

According to https://gcc.gnu.org/gcc-4.8/cxx0x_status.html and StackOverflow, gcc 4.8 which is the latest version shipped with Ubuntu Trusty 14.04 LTS does not support the part of C++11. I get compile errors because one of the overloads of std::regex_replace which is used in source/reflectionzeug/source/util.cpp is missing.

I suggest defaulting the above CMake option to false when a gcc below 4.9 is used. 4.9 officially supports regex. https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2011 http://isocpp.org/blog/2014/04/gcc-4.9.0
That means boost regex will be required to build reflectionzeug with gcc 4.8 but that is better than an out-of-the-box broken build.

Other solutions or suggestions welcome. At the bare minimum this should be documented somewhere so the issue can be easily resolved by hand in the CMake config (only used the GitHub search for the above option and found only ifdef and cmake code, so blame me when it is already documented).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.