cfe-lab / cfe-lab/bblab-server

Update or fork tcr-dist submode

Open
#5 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The production server is currently using an old commit (13e748f) of the tcr-dist repository.

Updating to the tcr-dist current commit (c839920) gives output data for the Filtered Contig Annotations and Consensus Annotations input file format that does not match the old commit (13e748f). So there needs to be a review of recent changes to the repository to determine the cause of the disparities and determine which output is correct to use.

It is also advisable to update tcr-dist to run with Python 3. Currently the must be modified so that cmd = 'python ... becomes cmd = 'python2 ....

Also, the production server has modifications to this repo to change the case-sensitivity of the input annotations files. This has been addressed in a recent commit of tcr-dist (e4b6a30).

The modifications are as follows:assert l['productive'].upper() == 'TRUE'
Here (make_10x_clones_file.py#L48) and here (make_10x_clones_file.py#L73)

The tcr-dist repo should probably be forked in order to make these changes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the referenced tcr-dist commits, focusing on the Filtered Contig Annotations and Consensus Annotations output differences and the changes in make_10x_clones_file.py at lines 48 and 73. Determine which output is correct, then verify the fork or update supports Python 3 and case-insensitive annotation values; done means the production integration uses the chosen version without output discrepancies.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.