cern-sis / cern-sis/react-formule

replace layer and accordion fields with an option inside field ui settings

Open
#125 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
16
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Right now fields can be set as modal or collapsible in the UI settings. This is in some way equivalent to layer and accordion fields (which are special types of array fields). We should unify this behavior by getting rid of the dedicated layer and accordion array fields and redesigning the modal and collapsible options to actually render components in a way similar to how layer and accordion do right now (with the better UI, error display, etc). This way we will be able to extend this behavior to other fields and not only arrays. Instead of having two separate toggles, we should have something like an antd radio button group (aka toggle group) to select between "normal", "layer/modal (tbd)" and "accordion" (maybe with an icon too) in the UI settings of the fields.

It would also be a good opportunity to update the array schema(s). See: https://github.com/rjsf-team/react-jsonschema-form/pull/3001 and https://github.com/rjsf-team/react-jsonschema-form/blob/main/packages/antd/src/templates/ArrayFieldTemplate/index.tsx

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.