cern-sis / cern-sis/react-formule

fix showAsModal settings modal

Open
#121 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
16
Forks
5
PR merge metrics
No merged PRs in 30d

Description

After the change to the schema settings #49, using the `PropKeyEditorObjectFieldTemplate` causes issues in the settings modal for the showAsModal feature, where options don't have correct margins. The `propKeyCollapse` class in said template is removing unwanted bottom margins, but since the modal is rendered inside this template, each of the fields inside the modal is in some way considered a `Collapse` element and therefore is having its margins removed. It's a bit tricky, so it needs more investigation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.