ceph / ceph/shaman

Auth bypass when using an optimised build

Open
#102 1 comment 0 reactions 1 assignee Claimed by @alfredodeza View on GitHub
Dominant language
Python
Stars
8
Forks
21
Avg merge
3h 54m
Merged PRs (30d)
2

Description

Similar to this: https://twitter.com/AlecMuffett/status/950699975767482370

> Oh, this is glorious: pysaml2 library uses an `assert` statement to check & reject users who use the wrong password; however when running with the optimiser enabled, all assert statements are stripped… so: anyone can log into anything with any password.

In here: https://github.com/ceph/shaman/blob/master/shaman/auth.py#L12-L13

```python
username, password = decoded.split(':')
assert username == conf.api_user
assert password == conf.api_key
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.