ceph / ceph/ceph-salt

Implement TerminalRenderer._render_failure

Open
#447 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
36
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Thanks to https://github.com/ceph/ceph-salt/pull/408 we are getting more information on cmd.run failures, but only in CursesRenderer.

Add this nice additional output to TerminalRenderer as well.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading TerminalRenderer._render_failure and the corresponding output added to CursesRenderer in ceph/ceph-salt#408. Implement equivalent failure details for terminal cmd.run failures, then verify that TerminalRenderer shows the same additional information as CursesRenderer.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.