ceph / ceph/ceph-salt

Use jinja macros to access the pillar data

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
ceph-salt-formula refactoring
Dominant language
Python
Stars
36
Forks
20
PR merge metrics
No merged PRs in 30d

Description

There is a lot of duplicate code to fetch data from the pillar, especially due to all the handling of non-existent keys in the pillar.

The objective is to create some jinja macros that can be used to reduce the amount of duplicate code.

See https://jinja.palletsprojects.com/en/2.10.x/templates/#macros

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by locating the repeated pillar lookups and their missing-key handling in the Jinja templates, then read the linked Jinja macro documentation. Done means the shared macros replace the duplicate access logic without changing behavior for existing and missing pillar keys.

Written by the indexing model from the issue text.

Assessment

Domain
devops
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.