ceph / ceph/ceph-build

Split up build_utils.sh

Open
#2,350 1 comment 0 reactions 1 assignee Claimed by @Adarsha1999 View on GitHub
Dominant language
Shell
Stars
44
Forks
105
Avg merge
1d 14h
Merged PRs (30d)
36

Description

`build_utils.sh` is nearly two thousand lines of shell that is difficult to understand. Functions call other functions, which have side-effects like modifying global variables, or creating new global variables that other functions must assume to have been populated later.

I have started to add some smaller, more narrowly-scoped files to `/scripts/` while developing `ceph-dev-pipeline`; I think we should aim to ultimately break the entire file up so that jobs can include only what they need to execute.

To enable a smooth transition, we could keep `build_utils.sh` around until the process is finished, and source newly-created files from there as their functionality is spit out from the larger file. We could do this one job at a time.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.