celestiaorg / celestiaorg/celestia-node

Fix TestLightRestartTestSuite/TestLightNodeResumesSamplingAfterRestart in tastora

Open
#5,187 0 comments 0 reactions 0 assignees View on GitHub
needs:triage
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

A lot of `ERROR module/p2p ... Host is not reachable from the public network`

Possible solutions:
Make the test independent of public-network reachability and flaky peer discovery by forcing local-only connectivity and seeding peers explicitly after restart.

1) In the failing restart test setup, disable strict reachability expectations

If the test currently waits for “publicly reachable” state (directly or indirectly), remove that as a success condition. In CI Docker networks, public reachability is commonly false and should not block DAS-resume assertions.

2) Seed at least one stable peer for the light node after restart

On restart, explicitly reconnect the light node to a known full/bridge peer address used in the test harness (instead of relying on DHT advertising/discovery timing).

Contributor guide

Open the contributing guide

Research direction

Locate TestLightRestartTestSuite/TestLightNodeResumesSamplingAfterRestart and run the failing test to observe the reachability error. Inspect its restart setup and test harness peer configuration; done means the test does not require public-network reachability, reconnects to a known peer after restart, and passes its DAS-resume assertions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.