celestiaorg / celestiaorg/celestia-node

misc(share/befp): improve logging in case of `good` errors

Open
#2,492 3 comments 0 reactions 0 assignees View on GitHub
area:fraud good first issue
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

We should make more informative logs about `good issues` during BEFP verification so as not to confuse users. There are 4 cases where we can conclude the BEFP is valid but can't finish verification([#1](https://github.com/celestiaorg/celestia-node/blob/6a6c68c42ff940467476c0a6876e7d986b0e84aa/share/eds/byzantine/bad_encoding.go#L196), [#2](https://github.com/celestiaorg/celestia-node/blob/6a6c68c42ff940467476c0a6876e7d986b0e84aa/share/eds/byzantine/bad_encoding.go#L204), [#3](https://github.com/celestiaorg/celestia-node/blob/6a6c68c42ff940467476c0a6876e7d986b0e84aa/share/eds/byzantine/bad_encoding.go#L215), [#4](https://github.com/celestiaorg/celestia-node/blob/6a6c68c42ff940467476c0a6876e7d986b0e84aa/share/eds/byzantine/bad_encoding.go#L224)). In these case we've verified shares but we can't finish BEFP verification, so we can conclude that BEFP is valid.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.