celestiaorg / celestiaorg/celestia-node

share/discovery: consider withdrawing connecting responsibility from Discovery

Open
#2,205 1 comment 0 reactions 0 assignees View on GitHub
area:shares needs:triage shrex
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

Discovery currently discovers and connects to peers. The goal is to make it work for Bitswap to catch up on those connections and sample from them. However, Discovery should not make connections and only provide peers, as connecting is the protocol's responsibility. This should also improve shrex protocols giving them more control.

The only way to do it is by enabling discovery in bitswap using a custom implementation that returns discovered peers for any requested CID

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.