celestiaorg / celestiaorg/celestia-node

`fraudserve.Service` should stop joined PubSub topics on `Stop`

Open
#2,040 0 comments 0 reactions 0 assignees View on GitHub
area:fraud needs:triage
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

This would be a simple 3 loc change, but it breaks our tests because PubSub does not allow closing topics if there are open subscriptions in them. They are open because they are closed asynchronously by context and there is no way to await when it's done or not. The solution is refactoring of circuit breaking described in #2041

Contributor guide

Open the contributing guide

Research direction

Start with fraudserve.Service.Stop and the PubSub topic and subscription lifecycle described in the issue. Read the circuit-breaking refactor in #2041 before changing this issue, then run the affected tests; done means joined topics can be stopped without PubSub rejecting open subscriptions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.