celestiaorg / celestiaorg/celestia-node
refactor(getters/shrex): construct peer manager inside shrex-getter
Open
area:p2p
area:shares
good first issue
kind:refactor
- Dominant language
- Go
- Stars
- 996
- Forks
- 1.1k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 34
Description
If ShrexGetter maintains the lifecycle of `peer.Manager`, it should also construct it, i.e. `peer.Manager` is a child of ShrexGetter but not a dependency. This also means that peer manager won't be part of FX dep graph, which is totally ok as the peer manager is singly purposed.
_Originally posted by @Wondertan in https://github.com/celestiaorg/celestia-node/pull/1743#discussion_r1105906346_
Contributor guide
Assessment
This issue has not been assessed yet.