celestiaorg / celestiaorg/celestia-node

testing(rpc): add additional test cases for ValidateAddr/SanitizeAddr

Open
#1,385 0 comments 0 reactions 0 assignees View on GitHub
area:rpc good first issue kind:testing
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

Ref #1378

Additional Test Cases needed
- https
- ipv6?
- no leading protocol
- localhost

We should add tcp test case.
also could refactor the tests since they should be the same for both.

Also, see if it makes sense to combine port validation with ValidateAddr.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.