celestiaorg / celestiaorg/celestia-node
Set `useShareIndexes=true` in availability_test.go
- Dominant language
- Go
- Stars
- 996
- Forks
- 1.1k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 34
Description
## Context
In celestia-app 0.7.0, there is a breaking change to the [shares.Split](https://github.com/celestiaorg/celestia-app/blob/c9dce391bc360bb5f068f43d4eb1681a9f35b710/pkg/shares/share_splitting.go#L22-L25).
This issue is a follow-up TODO from https://github.com/celestiaorg/celestia-node/pull/1147
## Problem
Unit tests in share/availability/light/availability_test.go currently set `useShareIndexes=false` because `useShareIndexes=true` will break unit tests unless we also update the transaction data used by tests to contain share indexes. This is non-trivial because the sample block used in the tests doesn't contain share indexes: https://github.com/celestiaorg/celestia-node/blob/30ed57feccf3584b56ec7d71f0a22b37e4b6899d/share/availability/light/availability_test.go#L337-L340
## Proposal
1. Update transaction data in test to contain share indexes
2. Set `useShareIndexes=true`
3. Remove `TODO` comment
Contributor guide
Assessment
This issue has not been assessed yet.