celestiaorg / celestiaorg/celestia-node

cmd: consistently output to stdout without logging

Open
#1,130 0 comments 0 reactions 0 assignees View on GitHub
area:cli good first issue pending:close
Dominant language
Go
Stars
996
Forks
1.1k
Avg merge
1d 6h
Merged PRs (30d)
34

Description

Currently, some of the commands write into the stdout directly or through logging.

Ideally, CLIs would write into stdout only without a logger or anything. Usually, when you run some CLI util, it does not have fancy logging in it. This is true for the panic/fatal log we introduce this logger for and for other possible cases where something needs to be logged out.
Super minor though, and we had a logger here before, which was not the best thing todo

_Originally posted by @Wondertan in https://github.com/celestiaorg/celestia-node/pull/1067#discussion_r971913770_

Contributor guide

Open the contributing guide

Research direction

Start by auditing the commands under cmd and identify which paths write output through logging instead of stdout. Trace the panic and fatal logging cases mentioned in the issue, then verify that CLI output consistently uses stdout without the logger.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.