cds-snc / cds-snc/platform-forms-client

Prevent shared accounts from be added as a collaborator on a published form

Open
#7,233 1 comment 0 reactions 0 assignees View on GitHub
:vertical_traffic_light: Moderate app security
Dominant language
TypeScript
Stars
46
Forks
16
Avg merge
1d 8h
Merged PRs (30d)
85

Description

## Context

As per our terms of use, we do not allow accounts to be created using shared email addresses / shared mailboxes, which is why the following account has been deactivated.

This for 2 main reasons:

1. To limit sharing passwords for the account to protect against breaches.
2. To have a clear record of which public servants had access to the public’s personal information.

## Description

We have alarms in place when an account is created to flag common shared account patterns in #forms-production-events.

We also have a second check in place when someone requests to publish a form / unlocks publishing ability for their account, confirmed not to be a shared account by support.

However there is another way that a shared email address can obtain access to a published form and its responses, by adding a collaborator but not having them be the "publisher" or adding them once the form is published.

Ideally we would close this loophole or have checks in place to prevent this situation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.