cdklabs / cdklabs/json2jsii

Code generation fails if `ref` does not start with `#/definitions/`

Open
#1,195 1 comment 3 reactions 0 assignees View on GitHub
p2
Dominant language
TypeScript
Stars
24
Forks
14
Avg merge
22m
Merged PRs (30d)
4

Description

Currently code generation for some schemas is failing due to `ref` not starting with `#/definitions/`. Here is where the error is being thrown: https://github.com/cdklabs/json2jsii/blob/main/src/type-generator.ts#L514-L518

Here are some examples of schemas that are failing with this,
* https://github.com/vinayak-kukreja/SchemaValidation/blob/main/chart-schemas/dagster.json#L546-L551
* https://github.com/vinayak-kukreja/SchemaValidation/blob/main/chart-schemas/nginx-ingress.json#L45-L50

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.