cdklabs / cdklabs/cdk-nag

feat: include current "additional rules" in Serverless Nag Pack

Open
#2,012 1 comment 0 reactions 0 assignees View on GitHub
feature-request
Dominant language
TypeScript
Stars
1k
Forks
86
Avg merge
26m
Merged PRs (30d)
4

Description

### Description

With the [Serverless Nag Pack](https://github.com/cdklabs/cdk-nag/blob/main/RULES.md#serverless) now released, I think the currently listed [additional rules](https://github.com/cdklabs/cdk-nag/blob/main/RULES.md#additional-rules) LambdaFunctionUrlAuth and LambdaEventSourceSQSVisibilityTimeout should be included in it.

### Use Case

Both of these rules fit thematically, they test serverless configurations

### Proposed Solution

Inclusion of those rules in the Serverless Nag Pack

### Other information

I'm happy to do this myself, but wanted to inquire whether there's a "process" to follow before adding rules to a pack. My assumption is that it's more flexible for the "thematic" Serverless one than for the industry standards or even AWS Solutions with its broad usage.

### Acknowledge

- [x] I may be able to implement this feature request
- [ ] This feature might incur a breaking change

Contributor guide

Open the contributing guide

Research direction

Start with RULES.md, comparing the Serverless and additional-rules sections, then locate the definition of the Serverless Nag Pack. Include LambdaFunctionUrlAuth and LambdaEventSourceSQSVisibilityTimeout in that pack and verify the published rules documentation reflects both entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
devops, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.