cdklabs / cdklabs/cdk-import

Readonly properties are skipped if they are in definitions path

Open
#482 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
57
Forks
12
Avg merge
11m
Merged PRs (30d)
8

Description

We have read-only properties in the definitions block of the Cloudformation schema [link](https://github.com/mongodb/mongodbatlas-cloudformation-resources/blob/e632a67d7693141009a60108bcda94843a67edcf/cfn-resources/alert-configuration/mongodb-atlas-alertconfiguration.json#L960)

From the code, it seems, we are only considering the read-only attributes from the properties path and skipping them if they are in the definitions path [link](https://github.com/cdklabs/cdk-import/blob/3c0b7f039df581eb3e236bf0dd3f658793cad9ec/src/cfn-resource-generator.ts#L40).

Screenshot 2023-01-26 at 1 20 22 AM

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.