cdklabs / cdklabs/cdk-cloudformation

Code generated for modules is incorrect

Open
#778 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
66
Forks
5
Avg merge
7d 43m
Merged PRs (30d)
1

Description

The properties that are generated for modules uses the root schema of the module, instead of the schema for its `Parameters`. For example:

![Screenshot 2024-11-19 at 12 03 17](https://github.com/user-attachments/assets/09a1a291-0a1b-478a-9aed-d44563d181ed)

Looking at the example template advertised by CloudFormation:

![Screenshot 2024-11-19 at 11 59 35](https://github.com/user-attachments/assets/b685c080-2cfa-49a1-b8f5-c1111fc27581)

Which means that these are the properties we should be exposing, and not `parameters` and `resources`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.