cdisc-org / cdisc-org/cdisc-rules-engine

Flagging "incomplete submission" validation in CLI

Open
#1,836 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
113
Forks
43
Avg merge
14h 51m
Merged PRs (30d)
14

Description

### Standard

CDISC SDTM/SDTMIG

### Reference Rule ID(s)

N/A

### Conformance Rule ID(s) (if published in CORE)

_No response_

### JIRA Ticket

_No response_

### Proposed Rule YAML

```YAML
N/A.
One of the great advantages of CORE is that one does not need to wait until all datasets are complete, but that it can be used already when starting executing the first mappings, e.g. on a single dataset (-dp parameter in the CLI)
When doing so for LB only, the generated Excel reports an issue "EX is not present in study when study includes protocol-specified study treatment", although EX was not in the list submittted to the engine. Together with other "rule evaluation error" messages in the Excel, this is very confusing - the lay user will think that something has really gone wrong, which is of course not the case.
Therefore I would like to see a CLI parameter that takes care that rules that cannot be evaluated or executed as the dataset is not in the list of datasets submitted to the engine are either not executed at all, or that messages for these are excluded from the report.
```

### Attach any sample test data file(s)

N/A

### Expected output

N/A

### Any Additional Information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by tracing CLI handling of the -dp parameter and the report-generation path, then reproduce the confusing messages with an LB-only submission. Done means the CLI supports the requested handling for rules whose datasets were not submitted, and the resulting Excel report no longer presents those cases as unexplained failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.