ccpem / ccpem/mrcfile

bug: possibility of writing invalid headers yielding unreadable files

Open
#51 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
86
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Hey @colinpalmer - as per our discussion:

In juglab/cryoCARE_pip#43 we saw that files were being written, copying the original header but not the extended header. The length of the extended header is stored in the header and as such the start of the data is incorrectly specified in the files `mrcfile` writes.

Proposal: check and update the header entry containing the number of bytes of the extended header when writing a file to avoid this problem in the future

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the file-writing path in mrcfile and review the behavior described in juglab/cryoCARE_pip#43. Confirm how the header records the extended-header byte count and define completion as writing files whose header value matches the extended header and whose data starts at the correct offset.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.