catchorg / catchorg/Catch2

`EXTRA_ARGS` of `catch_discover_tests` not used during discovery

Open
#2,382 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
21.5k
Forks
3.5k
Avg merge
3d 16h
Merged PRs (30d)
2

Description

**Describe the bug**

Our code outputs some warnings that get parsed as tests, e.g.,
```
$ ctest -N
Test project /home/pgrete/src/parthenon/build-catch2
Test #1: Kokkos::OpenMP::initialize WARNING: OMP_PROC_BIND environment variable not set
Test #2: In general, for best performance with OpenMP 4.0 or better set OMP_PROC_BIND=spread and OMP_PLACES=threads
Test #3: For best performance with OpenMP 3.1 set OMP_PROC_BIND=true
Test #4: For unit testing set OMP_PROC_BIND=false
Test #5: Adding MeshBlockData objects to a DataCollection
Test #6: Just check everything
```

We can suppress the warnings by adding `--kokkos-disable-warnings` to the command call.
I tried to use `catch_discover_tests(performance_tests EXTRA_ARGS "--kokkos-disable-warnings")` but the warning still show up as tests (see above)

**Expected behavior**
`EXTRA_ARGS` also be used for discovering tests.

**Reproduction steps**
I can try to come up with a MWE if required.

**Platform information:**

- OS: linux
- Compiler+version: g++ 11.2
- Catch version: v2.13.8

**Additional context**
Potentially also related to https://github.com/catchorg/Catch2/issues/1810

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.