catchorg / catchorg/Catch2

MSVC static code analysis warnings

Open
#1,955 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
21.5k
Forks
3.5k
Avg merge
3d 16h
Merged PRs (30d)
2

Description

catch.hpp(11784): warning C26439: This kind of function may not throw. Declare it 'noexcept' (f.6).
catch.hpp(4405): warning C26495: Variable 'Catch::Option::storage' is uninitialized. Always initialize a member variable (type.6).
catch.hpp(8973): warning C26495: Variable 'Catch::clara::detail::ResultValueBase::::m_value' is uninitialized. Always initialize a member variable (type.6).
catch.hpp(8971): warning C26495: Variable 'Catch::clara::detail::ResultValueBase::::m_value' is uninitialized. Always initialize a member variable (type.6).
catch.hpp(5833): warning C26415: Smart pointer parameter 'node' is used only to access contained pointer. Use T* or T& instead (r.30).
catch.hpp(5833): warning C26418: Shared pointer parameter 'node' is not copied or moved. Use T* or T& instead (r.36).
catch.hpp(8860): warning C26495: Variable 'Catch::clara::detail::Token::type' is uninitialized. Always initialize a member variable (type.6).
catch.hpp(5529): warning C26439: This kind of function may not throw. Declare it 'noexcept' (f.6).

**Platform information:**
- OS: Windows 10 (1909) / Windows Server 2016 (1607)
- Compiler+version: **MSVC 14.26.28801 (VS2019 version 16.6.1)**
- Catch v2.12.2

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the listed MSVC 14.26 warnings for Catch v2.12.2 on Windows, then inspect the referenced locations in catch.hpp: 4405, 5529, 5833, 8860, 8971, 8973, and 11784. The issue does not define an intended fix or tests, so confirm the desired warning policy before changing code; completion would require an agreed resolution and verification that the relevant warnings no longer appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.