catboost / catboost/catboost

MultiRMSEWithMissingValues for GPU implementation

Open
#2,961 1 comment 0 reactions 0 assignees View on GitHub
GPU objectives and metrics
Dominant language
C++
Stars
9.1k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have implemented the `MultiRMSEWithMissingValues` loss for GPU for my side project needs, I would like to contribute it to the main repository. I added the code of CUDA-kernels, registered them, and added the `else if` cases and enums in ~ same way as for `MultiRMSE` loss. Now it compiles & could be installed via wheel & used from python.

The remaining work from my perspective is to:
- provide `TargetBinarization` params in the right way, as I hardcoded the `NanMode` and `BorderCount` for now,
- run the current tests & add tests for GPU implementation, as I only compared GPU vs CPU loss over iterations on a random dataset (it converges) and used the loss in my project without any obvious issues,
- check any other places where the new loss or binarization params for it should be registered / added.

I could open a draft PR with the current state & do the remaining work with your guidance if it sounds good to you.

Thanks a lot!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.