catalinmiron / catalinmiron/react-typical

Every rerender causes a new instance to be attached

Open
#84 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
994
Forks
60
PR merge metrics
No merged PRs in 30d

Description

I am using [react-scroll-parallax](https://github.com/jscottsmith/react-scroll-parallax) and I am seeing an issue where if it rerenders on scroll in my case, a new instance of typical is attached to the element resulting in very janky visuals.

https://user-images.githubusercontent.com/806104/171450237-d8f226c7-498f-4b8a-a311-19f6b90b770c.mp4

Edit: Wrapping it in a PureComponent fixes the issue, but I feel like I shouldn't need to do this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.