castillo-io / castillo-io/angular-css

Preload with href array fails

Open
#82 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
464
Forks
84
PR merge metrics
No merged PRs in 30d

Description

in `$css.preload`, `stylesheet.href` is not tested for array-ness so,

this works...
```js
css: [
'stylesheets/style.css',
'https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.8.5/nv.d3.css',
'views/visualize-nvd3/visialize-nvd3.css'
]
```
but this fails...
```js
css: {
href: [
'stylesheets/style.css',
'views/visualize-nvd3/visialize-nvd3.css'
],
preload: true,
persist: true
},
```
The former works whether or not `preload` is set `true` in global options.

The problem is that
```js
var stylesheetLoadPromises = [];
angular.forEach(stylesheets, function(stylesheet, key) {
stylesheet = stylesheets[key] = parse(stylesheet);
stylesheetLoadPromises.push(
// Preload via ajax request
$http.get(stylesheet.href).catch(function (response) {
if(DEBUG) $log.error('AngularCSS: Incorrect path for ' + stylesheet.href);
})
);
});
if (angular.isFunction(callback)) {
$q.all(stylesheetLoadPromises).then(function () {
callback(stylesheets);
});
}

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.