castillo-io / castillo-io/angular-css

$http.get(...).error

Open
#81 4 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
464
Forks
84
PR merge metrics
No merged PRs in 30d

Description

i got this error from the angular-css.js
the style is correctly loaded
![image](https://cloud.githubusercontent.com/assets/3626339/24772166/8591f58e-1b10-11e7-8d56-89119981eb30.png)

and i corrected by changing the line 447 from
```
$http.get(stylesheet.href).error(function (response) {
if(DEBUG) $log.error('AngularCSS: Incorrect path for ' + stylesheet.href);
})
```
to
```
$http.get(stylesheet.href).then(function (response) {
if(DEBUG) $log.error('AngularCSS: Incorrect path for ' + stylesheet.href);
})
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in angular-css.js at line 447 and inspect the $http.get(stylesheet.href) handling described in the issue. Reproduce the reported error and verify that the fix preserves the stylesheet loading behavior and the DEBUG logging; done means the error no longer occurs for a correctly loaded style.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.