castillo-io / castillo-io/angular-css

$css.preload: calling the callback when it fails.

Open
#70 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
464
Forks
84
PR merge metrics
No merged PRs in 30d

Description

Hi,

Just a suggestion but the $css.preload only calls the callback when there is no error.

Probably be better to either call the callback passing in an error object when a failure happens or changing is to a promise so we can chain "then" and "catch"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.