casper-network / casper-network/casper-node

Provide more clear error message if the user-provided cors_origin is malformed

Open
#4,127 0 comments 0 reactions 1 assignee Claimed by @rafal-ch View on GitHub
tech-debt
Dominant language
Rust
Stars
399
Forks
224
Avg merge
15h 44m
Merged PRs (30d)
2

Description

In 1.5.2 we added the possibility for the operators to specify the CORS origin via config. The issue is that there is no proper error handling in warp, instead it simply panics when the provided string can't pass validation, leaving user with the "cryptic" error message, like "node panicked: missing scheme". Details and proposed solutions are described in the comment
[here](https://github.com/casper-network/casper-node/pull/4105#issuecomment-1632109250)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.